Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zfin import models #184

Merged
merged 63 commits into from
Jul 22, 2021
Merged

Zfin import models #184

merged 63 commits into from
Jul 22, 2021

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented May 6, 2021

round 2 attempt for a clean PR into master of all ZFIN models, without spurious deletes that we saw in: #182
The large number of commits is just a result of the number of files being too long to add in a single commit.
Travis is failing because the logging output is too long - should we just move to github actions?

@sierra-moxon sierra-moxon marked this pull request as ready for review May 6, 2021 18:50
@dustine32
Copy link
Contributor

@sierra-moxon The models I spot-checked look good! Unfortunately there's a bug we discovered in the ART workshop today that affects Noctua Form and ShEx. I'm testing a fix for this right now. Once it's merged into ontobio the models would need to be regenerated. Sorry!

@dustine32
Copy link
Contributor

@sierra-moxon OK, that bug's been fixed in ontobio so, if you git pull from master and regen, you should be good. Unfortunately, you'd also have to reset the modelstate to "production" again. Grr, need to add that option to the gocamgen code.

@sierra-moxon
Copy link
Member Author

@dustine32 - I regenerated the ZFIN models after updating to the latest version of ontobio to pull in the fix. I updated this branch accordingly so you should be able to see the differences here? Could you tell me what I'm looking for to see if it all worked properly with the fix? thanks a bunch! :). I also put in a PR for dev so that we could see it on noctua-dev (and I'm running the shex locally as well).

@dustine32
Copy link
Contributor

@sierra-moxon Oh, that fix should've added providedBy properties to all NamedIndividuals, like:

<http://model.geneontology.org/ZFIN_ZDB-GENE-000125-12/5d91e57a-b95d-4482-a269-1d15fd486dd9> a GO:0008285,
        owl:NamedIndividual ;
    dc:contributor "GOC:zfin_curators" ;
    dc:date "2004-09-17" ;
    ns2:providedBy "http://zfin.org" .

But I just see:

<http://model.geneontology.org/ZFIN_ZDB-GENE-000125-12/5d91e57a-b95d-4482-a269-1d15fd486dd9> a GO:0008285,
        owl:NamedIndividual ;
    dc:contributor "GOC:zfin_curators" ;
    dc:date "2004-09-17" .

Either code didn't update or there's another bug preventing this. I can eventually try the ZFIN GPAD myself.

Copy link
Contributor

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Loaded a few into my Noctua instance checking for state = "production," providedBy on all individuals and edges, etc.

@kltm
Copy link
Member

kltm commented Jul 22, 2021

Here we go!

@kltm kltm merged commit 1e0920a into master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants